Skip to content
This repository was archived by the owner on May 16, 2025. It is now read-only.

Conversation

@Qantt
Copy link
Contributor

@Qantt Qantt commented Apr 11, 2025

Description

I am using this package to communicate with SSE MCP server. I noticed that this package was not sending headers in node environment. This PR addresses this by starting to send headers there as well.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)

How Has This Been Tested?

  • Tests were updated to verify inclusion of the headers.
  • This has been manually tested by using this to communicate (and in this case to send headers) to an SSE MCP server.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@raphaelblum
Copy link

@benjamincburns tagged you because I saw you made a lot of PRs here

Can you or someone from the maintainer team please review the PR ?

@avi1mizrahi
Copy link

@benjamincburns tagged you because I saw you made a lot of PRs here

Can you or someone from the maintainer team please review the PR ?

+1
It is a blocker for us

@benjamincburns benjamincburns force-pushed the feature/send-headers-when-using-node-event-source-transport branch from 84d8f78 to 0288fae Compare May 12, 2025 15:47
@benjamincburns benjamincburns merged commit 8cfec54 into langchain-ai:main May 12, 2025
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants