Skip to content

Conversation

@langfuse-bot
Copy link
Collaborator

@langfuse-bot langfuse-bot commented Jan 9, 2026

Important

Make retention field optional in UpdateProjectRequest, retaining existing setting if omitted.

  • Behavior:
    • retention field in UpdateProjectRequest is now optional, retaining existing setting if omitted.
  • Code Changes:
    • Update update() method in Client.ts to reflect optional retention.
    • Update UpdateProjectRequest interface in UpdateProjectRequest.ts to make retention optional.

This description was created by Ellipsis for 753f4f0. You can customize this summary. It will automatically update as commits are pushed.

Disclaimer: Experimental PR review

Greptile Overview

Greptile Overview

Greptile Summary

This PR updates the auto-generated API client to make the retention field optional in UpdateProjectRequest. Previously, retention was a required field, which meant every project update had to specify a retention value even when the intent was to leave it unchanged.

Key Changes:

  • UpdateProjectRequest.retention changed from retention: number to retention?: number
  • JSDoc examples updated from retention: 1 to retention: undefined to reflect the optional nature
  • Documentation clarified that omitting retention will preserve the existing project retention setting

Behavior:
The change enables partial updates where callers can update project name/metadata without affecting retention settings. When retention is omitted or undefined, the server preserves the existing retention configuration. This is a backward-compatible change - existing code that provides retention values will continue to work unchanged.

Files Auto-Generated:
Both modified files contain the header "This file was auto-generated by Fern from our API Definition", indicating these changes were mechanically generated from the upstream API specification at langfuse/langfuse commit 99ffc45.

Confidence Score: 5/5

  • Safe to merge - clean auto-generated API spec update with no breaking changes
  • This is a straightforward auto-generated change that makes a field optional in an update request interface. The change is backward compatible (existing code providing retention will continue working), properly documented, and follows standard REST API patterns for partial updates. No logic errors, type safety issues, or edge cases detected.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/core/src/api/api/resources/projects/client/Client.ts 5/5 Updated JSDoc example to reflect optional retention field (retention: undefined instead of retention: 1)
packages/core/src/api/api/resources/projects/client/requests/UpdateProjectRequest.ts 5/5 Made retention field optional (retention?: number), updated JSDoc example and documentation to clarify omission preserves existing setting

Sequence Diagram

sequenceDiagram
    participant Client
    participant Projects
    participant API
    
    Note over Client,API: Update Project Request Flow
    
    Client->>Projects: update(projectId, request)
    Note over Projects: request.retention is optional
    alt retention provided
        Projects->>API: PUT /api/public/projects/{projectId}
        Note over API: Update retention to new value
        API-->>Projects: Project with updated retention
    else retention omitted
        Projects->>API: PUT /api/public/projects/{projectId}
        Note over API: Retain existing retention setting
        API-->>Projects: Project with unchanged retention
    end
    Projects-->>Client: HttpResponsePromise
Loading

Important Files Changed

File Analysis

Filename Score Overview
packages/core/src/api/api/resources/projects/client/Client.ts 5/5 Updated JSDoc example to reflect optional retention field (retention: undefined instead of retention: 1)
packages/core/src/api/api/resources/projects/client/requests/UpdateProjectRequest.ts 5/5 Made retention field optional (retention?: number), updated JSDoc example and documentation to clarify omission preserves existing setting

Sequence Diagram

sequenceDiagram
    participant Client
    participant Projects
    participant API
    
    Note over Client,API: Update Project Request Flow
    
    Client->>Projects: update(projectId, request)
    Note over Projects: request.retention is optional
    alt retention provided
        Projects->>API: PUT /api/public/projects/{projectId}
        Note over API: Update retention to new value
        API-->>Projects: Project with updated retention
    else retention omitted
        Projects->>API: PUT /api/public/projects/{projectId}
        Note over API: Retain existing retention setting
        API-->>Projects: Project with unchanged retention
    end
    Projects-->>Client: HttpResponsePromise
Loading

@vercel
Copy link

vercel bot commented Jan 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
langfuse-js Ready Ready Preview Jan 9, 2026 1:41pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@hassiebp hassiebp merged commit 9bb26c6 into main Jan 10, 2026
8 of 10 checks passed
@hassiebp hassiebp deleted the api-spec-bot-99ffc45 branch January 10, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants