Closed
Conversation
…variables for clarity, and reworked how the handshake of some functions operate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made several minor cleanups to the quantum chemistry to improve organization, readability, and laying the groundwork for future overhauls.
Major Changes
CatalystMetadatato no longer be Trotterization exclusive, it also now holds the number of electrons, orbitals, and active space fraction for traceability. (I need to find a way to add the algorithm parameters back in, with an algorithm-independent manner)Minor Changes:
scripts/AP-RE.pycode is laid out (I'd like to make this the standard throughout the project, at present they are not uniformly structured)