PHP 8.5 support #368
Open
PHP 8.5 support #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Signed-off-by: Pushpak Chhajed <[email protected]>
Contributor
|
Just verifying: all of these changes are related to PHP 8.5? 38 files changes seems like a lot, were the directories and file renaming part of 8.5 specifically? |
Member
Author
@joetannenbaum Yes, for PHP 8.5, we have a dependency on PEST 4 which is causing many changes. If you’d like, I can break this PR down into individual package updates and then ship only php8.5 related changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
PHP 8.5 Support: Added to CI test matrix and created AI guidelines for new features of PHP 8.5
Dependency Updates:
laravel/mcp→^0.4.0pestphp/pest→ Added^4.1.5supportlaravel/pint→^1.20.0Test Fixtures Refactor: Renamed
tests/fixtures/→tests/Fixtures/fixture()function that expects aFixtures/directory by defaultfixture()for paths andfixtureContent()for file contents to align with Pest 4 conventions with support for pest 3 and pest 2MCP Tools: Updated all tool classes to use new JsonSchema contract API (
Illuminate\Contracts\JsonSchema\JsonSchemaandTypeclass)