Add parameters support to terminable middleware#55488
Closed
onursimsek wants to merge 1 commit intolaravel:12.xfrom
Closed
Add parameters support to terminable middleware#55488onursimsek wants to merge 1 commit intolaravel:12.xfrom
onursimsek wants to merge 1 commit intolaravel:12.xfrom
Conversation
Contributor
|
Workaround:
<?php
namespace App\Http\Middleware;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Symfony\Component\HttpFoundation\Response;
class Sample
{
private readonly array $params;
public function handle(Request $request, \Closure $next, ...$params): Response
{
// 1. assign the arguments to an instance property
$this->params = $params;
return $next($request);
}
public function terminate(Request $request, Response $response): void
{
// 2. use the arguments when terminating
Log::info('terminating...', $this->params);
// IMPORTANT: This class should be registered as a singleton
// on a Service Provider, so the same instance is retrieved
// when terminating
}
} |
Member
|
See above workaround. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot use parameters in terminable middleware. It gives an error if used.
With this PR we can use parameters with terminable middleware.