Add multilanguage support for Team name reserved validation message.#71
Merged
WendellAdriel merged 2 commits intolaravel:mainfrom Apr 7, 2026
Merged
Add multilanguage support for Team name reserved validation message.#71WendellAdriel merged 2 commits intolaravel:mainfrom
WendellAdriel merged 2 commits intolaravel:mainfrom
Conversation
Member
|
Thanks for your contribution @luisprmat! 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we create a team and the team's name belongs to reserved list the validation doesn't pass and we see a message that had hardcoded English strings, making it impossible to translate for non-English users.
Solutions
__()helper so they can be translated via language files:$fail(__('This team name is reserved and cannot be used.')),Closure $failwithin aValidationRuleclass which returns an instance of theIlluminate\Translation\PotentiallyTranslatedStringclass we can chain the->translate()method:$fail('This team name is reserved and cannot be used.')->translate().I have chosen the first option for consistency with the other translation strings.