[0.x] Adding events to tool calls #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Katalam
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add a better event handling of tool calls I've added 3 new events
Laravel\Mcp\Server\Events\ToolCallFailedLaravel\Mcp\Server\Events\ToolCallFinishedLaravel\Mcp\Server\Events\ToolCallStartingInside the
CallToolMethod they will be dispatched through the normal framework dispatcher.I added 2 new test cases to catch the
ToolCallFinishedandToolCallFailedevents.I personally can now listen to these events instead of having a wrapper function for each tool.
A new doc block is possible
The mcp server dispatches three events when running tools:
Laravel\Mcp\Server\Events\ToolCallStarting,Laravel\Mcp\Server\Events\ToolCallFinished, andLaravel\Mcp\Server\Events\ToolCallFailed. TheToolCallStartingevent is dispatched immediately when the tool call starts running. Next, theToolCallFinishedevent is dispatched immediately after a tool call finished executing. If needed, theToolCallFailedevent is dispatched once a command fails validating inside the execution.