Skip to content

Allow consumers of the SDK to override the ID of users#195

Closed
hauthorn wants to merge 1 commit intolaravel:1.xfrom
hauthorn:1.x
Closed

Allow consumers of the SDK to override the ID of users#195
hauthorn wants to merge 1 commit intolaravel:1.xfrom
hauthorn:1.x

Conversation

@hauthorn
Copy link

@hauthorn hauthorn commented Jun 19, 2025

I've been in contact with Tim in support, because I would like to control the ID that is passed to Nightwatch.
This cannot be done as of now, as the events are logged with ->id(), which doesn't look at the user details provider.

There are a couple of reasons you'd want to be able to do this. For example if you have different Authenticable types, each backed by a different eloquent model. In this situation, User with id 42 and Admin with id 42 would be considered the same User in nightwatch. If you try to do this anyway, you break the UI in Nightwatch (see my bug report for screenshots).

I believe this change would avoid having two sources of ID's, and allow people with multiple eloquent models (or GDPR concerns) to use this package.

I've adjusted the tests to match how the UserProvider is actually instantiated inside the NightwatchServiceProvider.

I'm currently using this change on our Nightwatch account, and so far it has worked like a charm :-)

Edit: I've run the static analysis and pint locally. I'm not sure how to supply the keys to run the PR checks.

@hauthorn hauthorn reopened this Jul 31, 2025
@timacdonald
Copy link
Member

Thanks for the PR. This is on our radar to address. I'm closing this one for now and we will circle back to it shortly.

Thanks.

@timacdonald timacdonald closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants