Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.x] Make client RFC compatible #1744

Merged
merged 31 commits into from
Aug 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
3563bc2
make client RFC compatible
hafezdivandari May 18, 2024
a521a78
formatting
hafezdivandari May 18, 2024
e906821
drop support for Laravel 9
hafezdivandari May 18, 2024
7b33d5d
update upgrade guide
hafezdivandari May 19, 2024
45c5143
Merge branch '13.x' into 13.x-refactor-client
hafezdivandari May 30, 2024
5bca853
wip
hafezdivandari May 30, 2024
7d7addc
Merge branch '13.x' into 13.x-refactor-client
hafezdivandari Jun 4, 2024
38a36be
Merge branch '13.x' into 13.x-refactor-client
hafezdivandari Jun 27, 2024
aae97b1
Merge branch '13.x' into 13.x-refactor-client
hafezdivandari Jun 27, 2024
da3edf0
revert some changes
hafezdivandari Jun 27, 2024
676b43c
Merge branch '13.x' into 13.x-refactor-client
hafezdivandari Jul 29, 2024
d8e89ca
fix tests
hafezdivandari Jul 29, 2024
3c66423
wip
hafezdivandari Jul 29, 2024
e4931d5
fix tests
hafezdivandari Jul 29, 2024
2784abf
wip
hafezdivandari Jul 29, 2024
7edb0ef
wip
hafezdivandari Jul 29, 2024
14df618
wip
hafezdivandari Jul 29, 2024
82bc8da
wip
hafezdivandari Jul 29, 2024
baa6395
wip
hafezdivandari Jul 29, 2024
a579f4f
wip
hafezdivandari Jul 30, 2024
5c7944a
wip
hafezdivandari Jul 30, 2024
1149e9c
wip
hafezdivandari Jul 30, 2024
405d559
formatting
hafezdivandari Jul 30, 2024
1fc5d18
formatting
hafezdivandari Jul 30, 2024
407082f
formatting
hafezdivandari Jul 30, 2024
dfdec66
wip
hafezdivandari Aug 2, 2024
7235890
revert unrelated changes
hafezdivandari Aug 4, 2024
d3136c4
fix backward compatibility
hafezdivandari Aug 4, 2024
6aeb388
formatting
hafezdivandari Aug 4, 2024
86694ee
fix bc on update
hafezdivandari Aug 4, 2024
bf7ce0d
add tests for clients without grant_types
hafezdivandari Aug 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
formatting
hafezdivandari committed May 18, 2024
commit a521a78af36a279a2b738b004aa2d9bcaaa10fe4
6 changes: 2 additions & 4 deletions src/ClientRepository.php
Original file line number Diff line number Diff line change
@@ -134,8 +134,7 @@ protected function create(
?string $userId = null,
bool $confidential = true,
array $scopes = ['*']
): Client
{
): Client {
$client = Passport::client()->forceFill([
'user_id' => $userId,
'name' => $name,
@@ -196,8 +195,7 @@ public function createAuthorizationCodeGrantClient(
array $redirectUris,
bool $confidential = true,
?string $userId = null
): Client
{
): Client {
return $this->create(
$name, ['authorization_code', 'refresh_token'], $redirectUris, null, $userId, $confidential
);
2 changes: 1 addition & 1 deletion tests/Feature/ClientControllerTest.php
Original file line number Diff line number Diff line change
@@ -49,7 +49,7 @@ public function testUpdatingClient()
$this->actingAs($user);

$client = $this->post('/oauth/clients', [
'name' => 'new client', 'redirect_uris' => ['https://localhost']
'name' => 'new client', 'redirect_uris' => ['https://localhost'],
])->json();

$response = $this->put(
1 change: 0 additions & 1 deletion tests/Feature/Console/HashCommand.php
Original file line number Diff line number Diff line change
@@ -5,7 +5,6 @@
use Illuminate\Contracts\Hashing\Hasher;
use Illuminate\Support\Str;
use Laravel\Passport\Client;
use Laravel\Passport\Passport;
use Laravel\Passport\Tests\Feature\PassportTestCase;

class HashCommand extends PassportTestCase