Skip to content

Fix heredoc/nowdoc in blade files #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix heredoc/nowdoc in blade files #297

wants to merge 1 commit into from

Conversation

N1ebieski
Copy link
Contributor

@danie-ramdhani
Copy link

oh yeah. cool stuff dude 👏

before:
before

after:
after

i wonder why blade heredoc/nowdoc is not highlighted in blade file 🤔

before:
before2

after:
after2

@N1ebieski
Copy link
Contributor Author

N1ebieski commented Mar 7, 2025 •
edited
Loading

@danie-ramdhani

i wonder why blade heredoc/nowdoc is not highlighted in blade file

Because there is no such heredoc/nowdoc in the https://github.com/laravel/vs-code-extension/blob/main/syntaxes/blade.tmLanguage.json#L1035-L1664 file. What's the difference between <<<HTML and <<<BLADE ? Concatenating string variables via {{ }} ?

@danie-ramdhani
Copy link

danie-ramdhani commented Mar 7, 2025 •
edited
Loading

@danie-ramdhani

i wonder why blade heredoc/nowdoc is not highlighted in blade file

Because there is no such heredoc/nowdoc in the https://github.com/laravel/vs-code-extension/blob/main/syntaxes/blade.tmLanguage.json#L1035-L1664 file. What's the difference between <<<HTML and <<<BLADE ? Concatenating string variables via {{ }} ?

yep! especially for livewire inline/volt component or laravel blade render facade.

image

@N1ebieski N1ebieski mentioned this pull request Mar 7, 2025
Open
@N1ebieski
Copy link
Contributor Author

@danie-ramdhani so the problem with blade heredoc/nowdoc in only in blade files, right?

I've created a separate PR for this #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: <<<'JS' heredoc in blade file spoils syntax highlighting

2 participants

@N1ebieski @danie-ramdhani