Fix PHP String Concatenation in Output Panel Interpreted as Shell Commands

[N1ebieski]

Fixes #271, #329

Probably fixes #458

If the contents of the file with the PHP code contains string with concatenation for example:

<?php

$className = "App\\DynamicApp\\Models\\" . ucfirst($relationshipField->attribute) . "Model";

then the command will look like this:

php-parser detect "<?php

\$className = \"App\\DynamicApp\\Models\\\\" . ucfirst(\$relationshipField->attribute) . \"Model\";"

There is one more backslash after "Models\\" than there should be. Then the command returns an error:

bash: syntax error near unexpected token ('`

I suggest to remove one backslash from replacements in the cleanArg function:

replacements.push([/\\"/g, '\\\"']);

because 2nd replacement in the line:

replacements.push([/\"/g, '\\"']);

duplicates backslashes in that case.

[joetannenbaum]

The problem is that this breaks something like the following:

$myName = "Joe \"Howdy\" Tannenbaum";

Searching out a more reliable (preferably built-in) argument escaping mechanism in Node that works well cross-platform.

[N1ebieski]

@joetannenbaum hmmm maybe just add a negative lookbehind and lookahead:

replacements.push([/(?<!\\)\\(?!\\)"/g, '\\\\"']);

Then only a single, unescaped \ backslash will be escaped.