Add SignificantWordsLM, tests, and py3 compatibility #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(these NaNs are caused by `-inf - -inf`)
ignore out-of-vocabulary terms: this prevents errors but does not "handle unseen words" as expressed in #1
format some docstrings
switched to backwards-compatible annotations, because while python may be PEP 585-ready, mypy does not deal with builtin generics yet
(*facepalm* for major oversight)
parsimonize specific with fixed w=1/3; format floats in lambda logging
(this can significantly reduce the memory complexity)
moved test fixture; updated copyright in license statement
aolieman
changed the title
SignificantWordsLM, tests, and py3 compatibility
Author
|
I got impatient and (also) released my additions under a new name: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a reference implementation of the Significant Words Language Model by Dehghani et al.
I also updated the package to be compatible with python 3.7, added type annotations, and wrote some tests. The API remains backwards-compatible, but compatibility with python 2.x is broken as it stands.
I can see three roads going forward:
sixweighwords3Please let me know if this contribution has your interest, and what needs to be done to include it in a new release on PyPI.