Feature/1412 remove limit on thruster on time #380
+115
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
thrMomentumDumping limits the onTime from the thrusters to the frequency of the module. This can be limiting if the control frequency is pretty high, for example 10 Hz result in a max on time of 0.1 seconds. This PR adds the ability to provide a multiple of the control period:
maxNumOfDtFiringTimes. When you combine this change and themaxCounterValue, the module can be tuned to give desired performance during desats.Verification
Previous tests were unmodified and they all still pass. One test was added to test the new functionality. The new functionality can be seen in the test where the control period is set to 0.1 seconds, with the
maxNumOfDtFiringTimesset to 3 and themaxCounterValueset to 5. You can see that when there is more time left to burn than 30.1, then the firing time is set to 0.3. If there is less burn time than 30.1, then the burn time is set to the remainder. After the multiple of dt firings has been executed, the burn time is set back to zero until the counter restarts.Documentation
The Basilisk-thrMomentumDumping documentation has not been updated to reflect the change.
Future work
None