Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
==========================================
+ Coverage 91.89% 93.43% +1.54%
==========================================
Files 36 37 +1
Lines 2553 2605 +52
==========================================
+ Hits 2346 2434 +88
+ Misses 207 171 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
94affac to
ccfcd65
Compare
- Improve coverage of comparisons and remove unnecessary checks in their evaluate methods (in parsing loop) - Improve coverage of encodings - Improve coverage of packets - Add coverage for minimum dtype functions in xarr module
37989ab to
9cee12e
Compare
greglucas
approved these changes
Mar 10, 2025
Collaborator
greglucas
left a comment
There was a problem hiding this comment.
Yeah, one of us will have to fix some merge conflicts, but overall this doesn't seem like it will cause too much headache CCSDSPacket -> Packet mostly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that we had low-ish coverage on a couple modules, mostly on the error-handling since most of the tests are run correctly. I found some locations where we were checking for exception cases in
evaluatemethods when we should have been pre-checking in either init orfrom_xml.I added some additional coverage to the packets.py module but I'm thinking that will probably need rework after @greglucas 's refactoring in #140
Checklist