Open
Conversation
patkenneally
requested review from
JRodriguezLASP,
JulianHammerl,
codyallard28 and
thibaudteil
patkenneally
force-pushed
the
fix/stepper-motor-not-stopping
branch
from
f0b7cd2 to
9e5bf8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The stepperMotor module was not correctly determining the step completed condition in the case where a step duration that was not a factor of the task step time. This PR fixes the condition to check for step completed. Three additional tests are added to ensure
Verification
Ci tests run successfully.
Documentation
None updated, none invalidated.
Future work
NA