Master with desmos #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Text command improvements
Add verbal support for reading and navigating nthroots
add support for overleftrightarrow, and cleanup styles for overleftarrow and overrightarrow
Add a configuration flag to disable copy & paste
add support for overarc
remove important modifiers
less version 3.0.0 causes problems with inline javascript, which was breaking the build
update less version dependency
we aren't gauranteeing that controller.options is an object
More minus signs
add support for overarc
We were trying to index into, e.g., `parent.parent.ends[L]`, but it's possible that a parent is actually equal to `0`, in which case there is no `ends` property and the lookup throws. Reported by a partner, but we're also seeing this occasionally on WWW.
Add defensive checks for property lookup on parent-parent nodes
This is a new feature of npm that specifies exact package versions. It gets generated every time you run `npm install` (or `make` or `make basic`), so we need to either check this in or ignore it. Checking it in is helpful because it avoid surprise version differences between users.
Check in package-lock.
…boardevents restore legacy substituteKeyboartdEvents option
ARIA Label Refinements
…-build mathquill#797 less 3.0.1 breaks build because @var:; is non standard
…ead-of-gray use semi-transparency instead of gray
For general mathspeak computation, ignore the start and end block delimiters. Speak them when navigating. Also stops separating individual letters inside style blocks so they are read aloud as normal text.
Also adds tests.
…e-mathspeak Improve Mathspeak for Text Blocks
Writing -> converts to \to arrow
Interpret → as \to when it is pasted in
* Call updateMathspeak from the primary setAriaLabel() method if the active Mathquill element does not have focus (this was previously called in textarea, but wouldn't necessarily fire if an outsider was setting the label via the public API). * Add the colon symbol only when computing an aria-label + mathspeak for the active Mathquill-- should restore previously expected behavior.
Also updates tests.
…dering Consolidate ARIA label update code and use hidden span for static math
…update Short-circuit efficient latex update if old and new values are identical
jQuery 3.x has introduced a bunch of different focus bugs in the process of attempting to migrate to using native focus events in more cases, some of which remain unfixed in the latest version (3.6.0). Examples: * jquery/jquery#4859 * jquery/jquery#4856 * jquery/jquery#4950 * jquery/jquery#4867 Some unknown bug in this general class can make it so that Mathquill public api focus calls stop working because using jQuery to programatically trigger focus breaks. Work around this by switching to triggering native focus events instead of jQuery focus events.
Use native focus events insted of jQuery focus events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.