-
Notifications
You must be signed in to change notification settings - Fork 103
Create contributing video guide #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create contributing video guide #520
Conversation
Signed-off-by: Vivek Vishal <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Draft... |
Not ready for review. |
Ha! This isn't even a draft. |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: Vivek Vishal <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Signed-off-by: vishalvivekm <[email protected]>
Hi @vishalvivekm , The contribution documentation structure looks good overall. I found the title "Contributing Videos" a bit confusing. At first glance, I thought it was a guide on how to make videos (like choosing topics or recording tips), rather than its actual focus on how to contribute video-related documentation or add videos to our gallery. To improve clarity and consistency, here are two possible suggestions:
What are your thoughts on this? 🤠 |
Hi @zihanKuang, thank you for your feedback.
Yeah, I acknowledge it being the case. I renamed it to
Makes sense, instead of having another section dedicated to "Contributing Videos", We can have just one section "Contributing to Docs" and move the "adding videos" guide to it. There's a To-do:
|
Signed-off-by: vishalvivekm <[email protected]>
Notes for Reviewers
This PR fixes #512
kanvas/references
to/contributing
, andContributing to video gallary
guide inside itcontent/en/videos
, set todraft: true
Signed commits