-
Notifications
You must be signed in to change notification settings - Fork 103
Add documentation for comment cloning #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Zihan Kuang <[email protected]>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Zihan Kuang <[email protected]>
@@ -78,6 +78,39 @@ After resolving a comment thread, you can access the comment history to review p | |||
|
|||
Manage your comment history by clicking on the "View Comment History" button. This allows you to revisit past discussions and decisions, ensuring that important context is never lost. | |||
|
|||
### Copying or Cloning Comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to capture a couple of suggestions as to why you might want to use this feature. Capturing this information here and maybe in a separate blog post (that covers more on the subject of design reviews) could be good.
I will propose additional text.
- **Threads**: All replies in the thread are included. | ||
- **Name**: If the comment has a name, the clone keeps the same name. | ||
- **Placement**: You can paste the comment into the same design or a different one. | ||
- **Notifications**: Replies to the cloned comment will notify participants unless they’ve muted the thread. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upon duplication, will the design owner be notified of the creation of this duplicate comment?
Upon duplication, will participants be notified of the creation of this duplicate comment?
@@ -78,6 +78,39 @@ After resolving a comment thread, you can access the comment history to review p | |||
|
|||
Manage your comment history by clicking on the "View Comment History" button. This allows you to revisit past discussions and decisions, ensuring that important context is never lost. | |||
|
|||
### Copying or Cloning Comments | |||
|
|||
You can reuse a comment by cloning it. This is helpful when you want to move a discussion to a new place or carry it over to another design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An alert warning is probably needed here. If a comment with multiple participants is copied, then pasted into a new design, not all participants are guaranteed to have access to the other design.
In other words, coping of comments into another design has no effect on the sharing settings of that design.
@@ -78,6 +78,39 @@ After resolving a comment thread, you can access the comment history to review p | |||
|
|||
Manage your comment history by clicking on the "View Comment History" button. This allows you to revisit past discussions and decisions, ensuring that important context is never lost. | |||
|
|||
### Copying or Cloning Comments | |||
|
|||
You can reuse a comment by cloning it. This is helpful when you want to move a discussion to a new place or carry it over to another design. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting that the reason to copy of a comment is for purposes of reuse... 🤔. Perhaps, that's a less common use of the Duplicate function.
Signed-off-by: Lee Calcote <[email protected]>
merge conflicts eliminated. |
Co-authored-by: Lee Calcote <[email protected]> Signed-off-by: Zihan Kuang <[email protected]>
Signed-off-by: Zihan Kuang <[email protected]>
@leecalcote @miacycle As for the Renaming Comments part — it's been added in #519. If the content there looks good to merge, I can go ahead and resolve the conflicts, since both PRs modify the same page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go here.
@leecalcote Thanks! I’ll go ahead and resolve the conflict. |
Signed-off-by: Lee Calcote <[email protected]>
Merge conflicts eliminated. |
This PR enhances the Reviewing Designs documentation by:
Copying or Cloning Comments
.