Add precompiled xcframework binary option for SPM#228
Closed
woohyunjin06 wants to merge 2 commits intolayoutBox:masterfrom
Closed
Add precompiled xcframework binary option for SPM#228woohyunjin06 wants to merge 2 commits intolayoutBox:masterfrom
woohyunjin06 wants to merge 2 commits intolayoutBox:masterfrom
Conversation
Member
|
@OhKanghoon has opened this PR removing the need to define |
Author
|
@lucdion Hi, I saw his PR too, and I think that can give users a better experience, so I don't think this PR is necessary if that PR is merged |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
FLEXLAYOUT_SWIFT_PACKAGE=1to theGCC_PREPROCESSOR_DEFINITIONSfor each target.This can cause inconvenience when creating and distributing other Swift Packages that depend on FlexLayout.
(In my case, issues occurred during a build with Tuist.)
In order to simplify this setup process, I proposed to offer a precompiled binary.
Changes
postfix operator %statements to applyBUILD_LIBRARIES_FOR_DISTRIBUTION(Already declared inPercent.swift)Related