Enhance AWHP plant template to support 4-pipe heat pumps#4657
Open
AntoineGautier wants to merge 98 commits into
Open
Enhance AWHP plant template to support 4-pipe heat pumps#4657AntoineGautier wants to merge 98 commits into
AntoineGautier wants to merge 98 commits into
Conversation
…ssueXX_hybridHpPlant
…elica-buildings into issue4512_polyvalentHpPlant
…elica-buildings into issue4512_polyvalentHpPlant
…elica-buildings into issue4512_polyvalentHpPlant
- This avoids OCT solver failure while still allowing validating the hydronics.
…elica-buildings into issue4512_polyvalentHpPlant
- WARNING: Includes major changes in configuration parameters.
…ssue4512_polyvalentHpPlant
- Would require unequally sized primary pumps with a staging matrix.
- The opposite 'have_pumPriComHp' is not specific enough.
…ssue4512_polyvalentHpPlant
…ssue4512_polyvalentHpPlant
- The Pre block from master breaks OCT support: requires ibpsa/modelica-ibpsa#2136
E.g. `Plants.HeatPumps_combin0`
…ssue4512_polyvalentHpPlant
8ead0f0 to
b003936
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #4512, with one exception: plants with modular polyvalent HP are not yet supported. Instead, the controller implements staging and valve/pump control logic for an arbitrary number of polyvalent HP. This reproduces the functionality of a modular polyvalent HP, just with the control logic hosted in the BAS instead of the HP onboard controller. The validation model
Buildings.Templates.Plants.HeatPumps.Validation.AirToWaterPolyvalentreproduces the same plant layout as G36 Addendum L Figure A-35 (Primary-Only Modular Air-to-water Heat Pump/Chiller Plant), using individual polyvalent units instead of a single modular system.The Python script
Buildings/Resources/Scripts/travis/templates/Plants.HeatPumps.pyhas been updated to test all valid plant configurations.The validation models for several refactored control blocks (and therefore the main controller and the template model) fail to compile with OCT, due to ibpsa/modelica-ibpsa#2136 (to be addressed soon).
Most of the existing Extension Blocks under
Buildings.Templates.Plants.Controlshave also been refactored using only CDL Elementary Blocks.Buildings.Templates.Plants.Controls.Utilities.StageIndexBuildings.Templates.Plants.Controls.Utilities.TimerWithResetwas refactored as proposed by @JayHuLBL inissue2293_chiller_plant_seq. It will be a duplicate of the block included in that latter branch when both branches are merged. @JayHuLBL let me know how you want to proceed: add a TODO in Chiller plant sequences #2299 to removeBuildings.Templates.Plants.Controls.Utilities.TimerWithResetbefore merging?Buildings.Templates.ZoneEquipment.Validation.VAVBoxCoolingOnlyOn the master branch (0192839), this model is not excluded in
conf.yml.However, it fails to translate with OMC on this feature branch (14d4519).
Considering the changed files, I cannot explain why this fails.
Curiously, when checking out this model from the master branch, it also fails to translate: see the log below.
The similar model
Buildings.Templates.ZoneEquipment.Validation.VAVBoxReheatis already excluded inconf.yml.I also excluded
VAVBoxCoolingOnlyin the latest commit 8ead0f0.