Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule on post-processing query results #232

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Conversation

szarnyasg
Copy link
Member

No description provided.

@szarnyasg szarnyasg requested a review from ArnauPrat March 1, 2023 14:06
@ArnauPrat
Copy link
Contributor

ArnauPrat commented Mar 2, 2023

First and foremost, I'd talk about the "test driver" instead of the benchmark client.
I think we should consider these two things:

  • Lossless compression during the communication between the test driver and the DBMS should be allowed. For instance, as long as in the DBMS you use a data type that conforms with the schema requirements for a given attribute in the schema, you can apply compression to send it back to/from the driver and decompress it. The same applies for query parameters and results. In both ends you need to have fully qualified datatypes, but during transmission, you can apply compression. So for query 14, the implementation should ultimately produce a floating point score.
  • All computing for a given query, needs to happen in the DBMS. So for query 14, you can defer the division til the end, but it needs to happen there before transmission. In other words, partial results cannot be transmited.

@szarnyasg
Copy link
Member Author

Hello @ArnauPrat, a bit belatedly, but I applied your feedback to the documentation. Thanks!

@szarnyasg szarnyasg merged commit 14b0d6f into main Jan 13, 2024
1 check passed
@szarnyasg szarnyasg deleted the post-processing-results branch January 13, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants