Skip to content

Add renderLoading and renderError support for each of gallery items #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
almirfilho wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add renderLoading and renderError support for each of gallery items #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd6c919
Add renderLoading and renderError support for each of gallery items
almirfilho Jun 7, 2017
b31ab42
Updates readme with renderLoading and renderError props
almirfilho Jun 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ This component utilizes **[@ldn0x7dc/react-native-view-pager](https://github.com
* **initialPage**, **pageMargin**, **onPageSelected**, **onPageScrollStateChanged**, **onPageScroll**: inherited from **[@ldn0x7dc/react-native-view-pager](https://github.com/ldn0x7dc/react-native-view-pager)**. Check the link for more details.
* **onSingleTapConfirmed**: Called after user single taped( not a double tap)
* **onGalleryStateChanged**: function. (idle) => {}.
* **renderLoading**: (optional) function to render anything while the image loads (e.g. a spinner).
* **renderError**: (optional) function to render anything if the image fails to load (e.g. an error message).



Expand Down
76 changes: 56 additions & 20 deletions library/Gallery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
import React, { Component, PropTypes } from 'react';
import {
View
} from 'react-native';

import { View, StyleSheet } from 'react-native';
import Image from 'react-native-transformable-image';
import ViewPager from '@ldn0x7dc/react-native-view-pager';
import {createResponder} from 'react-native-gesture-responder';
import { createResponder } from 'react-native-gesture-responder';


export default class Gallery extends Component {
Expand All @@ -16,6 +13,8 @@ export default class Gallery extends Component {

initialPage: PropTypes.number,
pageMargin: PropTypes.number,
renderLoading: PropTypes.func,
renderError: PropTypes.func,
onPageSelected: PropTypes.func,
onPageScrollStateChanged: PropTypes.func,
onPageScroll: PropTypes.func,
Expand All @@ -31,6 +30,8 @@ export default class Gallery extends Component {
pageCount = 0;
gestureResponder = undefined;

state = { status: {} };

constructor(props) {
super(props);
}
Expand Down Expand Up @@ -219,25 +220,47 @@ export default class Gallery extends Component {
}

renderPage(pageData, pageId, layout) {
const { onViewTransformed, onTransformGestureReleased, ...other } = this.props;
const {
onViewTransformed, onTransformGestureReleased, renderLoading, renderError,
...other
} = this.props;

return (
<Image
{...other}
onViewTransformed={((transform) => {
onViewTransformed && onViewTransformed(transform, pageId);
}).bind(this)}
onTransformGestureReleased={((transform) => {
onTransformGestureReleased && onTransformGestureReleased(transform, pageId);
}).bind(this)}
ref={((ref) => {
this.imageRefs.set(pageId, ref);
}).bind(this)}
key={'innerImage#' + pageId}
style={{width: layout.width, height: layout.height}}
source={{uri: pageData}}/>
<View>
{renderLoading && !this.state.status[pageId] &&
<View style={Style.underlay}>{renderLoading()}</View>}

{renderError && this.state.status[pageId] === 'error' &&
<View style={Style.underlay}>{renderError()}</View>}

<Image
{...other}
onViewTransformed={((transform) => {
onViewTransformed && onViewTransformed(transform, pageId);
}).bind(this)}
onTransformGestureReleased={((transform) => {
onTransformGestureReleased && onTransformGestureReleased(transform, pageId);
}).bind(this)}
ref={((ref) => {
this.imageRefs.set(pageId, ref);
}).bind(this)}
key={'innerImage#' + pageId}
style={{width: layout.width, height: layout.height}}
source={{uri: pageData}}
onLoad={this.setLoadedStatus.bind(this, pageId)}
onError={this.setErrorStatus.bind(this, pageId)}/>
Copy link

@sroze sroze Jul 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add a listener on onProgress, that way you could even call renderLoading with the progress. See react-native-image-progress

Copy link

@chrusart chrusart Sep 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you look at:
meliorence/react-native-image-gallery#13

p. 5.

This way you can achieve whatever you want with a custom Image component.

It doesn't look like @ldn0x7dc is maintaining this repo and it's dependencies.

</View>
);
}

setLoadedStatus(pageId){
this.setState({status: {...this.state.status, [pageId]: 'loaded'}});
}

setErrorStatus(pageId){
this.setState({status: {...this.state.status, [pageId]: 'error'}});
}

resetHistoryImageTransform() {
let transformer = this.getImageTransformer(this.currentPage + 1);
if (transformer) {
Expand All @@ -250,3 +273,16 @@ export default class Gallery extends Component {
}
}
}


const Style = StyleSheet.create({
underlay: {
position: 'absolute',
top: 0,
bottom: 0,
left: 0,
right: 0,
alignItems: 'center',
justifyContent: 'center'
}
});