Skip to content

Rework recruitment items to become datapacks#10342

Merged
Raycoms merged 9 commits intoversion/mainfrom
feature/rework_recruit_costs
Mar 30, 2025
Merged

Rework recruitment items to become datapacks#10342
Raycoms merged 9 commits intoversion/mainfrom
feature/rework_recruit_costs

Conversation

@Thodor12
Copy link
Copy Markdown
Contributor

Changes proposed in this pull request

  • Recruit costs use datapacks in favor of configuration values
  • Improves the recruit logic for tavern spawning and entity conversion to use similar logic

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

Comment thread src/main/java/com/minecolonies/core/event/EventHandler.java
# Conflicts:
#	src/main/java/com/minecolonies/api/compatibility/CompatibilityManager.java
#	src/main/java/com/minecolonies/api/configuration/ServerConfiguration.java
Raycoms
Raycoms previously approved these changes Nov 24, 2024
Comment thread src/main/java/com/minecolonies/core/event/EventHandler.java Outdated
# Conflicts:
#	src/main/java/com/minecolonies/api/compatibility/CompatibilityManager.java
#	src/main/java/com/minecolonies/api/compatibility/ICompatibilityManager.java
#	src/main/java/com/minecolonies/api/configuration/ServerConfiguration.java
#	src/main/java/com/minecolonies/core/event/FMLEventHandler.java
@Raycoms Raycoms merged commit 3d18b75 into version/main Mar 30, 2025
5 checks passed
@Raycoms Raycoms deleted the feature/rework_recruit_costs branch March 30, 2025 15:24
@Ashlockheart Ashlockheart mentioned this pull request Apr 1, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants