Fix enchanted book requests 1.21#10791
Merged
someaddons merged 7 commits intoversion/1.21from Apr 21, 2025
Merged
Conversation
Compatmanager is now side specific, due to Itemstacks now being side sensitive Fix enchanted books now showing up on sync due to item comparisons failing as CHECKED_NBT_KEYS were loaded too late Switched compat manager sync to player login, as it has to happen after registries got loaded
Raycoms
reviewed
Apr 14, 2025
Contributor
|
If |
Contributor
Author
|
good call, currently it seems to mostly affect enchanted books as their data components store a holder to a registry object but should fix the others too |
Contributor
Author
|
Btw I updated this and added the furnace recipes |
Raycoms
approved these changes
Apr 20, 2025
2 tasks
Raycoms
pushed a commit
that referenced
this pull request
May 14, 2025
Fixes JEI recipe errors as a result of later CompatibilityManager (Fix enchanted book requests 1.21 #10791) Fixes client-side CompatibilityManager not populating properly on /reload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Closes #
Changes proposed in this pull request
Testing
Review please