Fix/building rotation#10809
Merged
someaddons merged 2 commits intoversion/mainfrom Apr 18, 2025
Merged
Conversation
Raycoms
reviewed
Apr 18, 2025
| @@ -43,13 +46,11 @@ private ConstructionTapeHelper() {} | |||
| */ | |||
| public static void placeConstructionTape(@NotNull final IWorkOrder workOrder, @NotNull final Level world, final IColony colony) | |||
Contributor
Author
There was a problem hiding this comment.
It's already calculated, there's no point calculating it again. Plus the act of calculating it re-rotated the blueprint, since loadBlueprint returns a (possibly cached) pre-rotated copy.
Contributor
Author
There was a problem hiding this comment.
It's probably bad coding style that calculateCorners (not this one, but the call that was removed) also mutates the blueprint, but that's probably a refactor for another time. I did at least update the javadoc for it 😆
Raycoms
approved these changes
Apr 18, 2025
someaddons
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10803
Changes proposed in this pull request
Testing
Review please (should port, with WO refactor)