Skip to content

Update JDK version in README.md#10883

Open
ada-phillips wants to merge 1 commit intoldtteam:version/mainfrom
ada-phillips:patch-1
Open

Update JDK version in README.md#10883
ada-phillips wants to merge 1 commit intoldtteam:version/mainfrom
ada-phillips:patch-1

Conversation

@ada-phillips
Copy link
Copy Markdown
Contributor

Update developer setup instructions to refer to JDK 17

Closes #10650

Changes proposed in this pull request

  • Update developer setup instructions for JDK 17

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

Update developer setup instructions to refer to JDK 17
@Nightenom
Copy link
Copy Markdown
Member

1.21 requires jdk 21, so might be worth going with that instead

@ada-phillips
Copy link
Copy Markdown
Contributor Author

1.21 requires jdk 21, so might be worth going with that instead

Yeaaah, I thought about that, but I wasn't sure where that branch is in terms of priority/releasability? There seems to be a pretty sizable gulf between the release/main and release/1.21

Maybe I can do a PR to that branch for a README update for jdk 21?

@someaddons
Copy link
Copy Markdown
Contributor

I think we should mention both, telling ppl that version/main uses jdk 17 and version/1.21 jdk 21

Copy link
Copy Markdown
Contributor

@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make a PR to 1.21 with the 21 java instructions then too, yes =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting up dev env, gradle jvm version mismatch

4 participants