Conversation
- BuildingConstants.java: renaming NBT Tag - BuildingMiner.java: renaming BlockPos var, removing hardcoded requests for cobblestone, renaming var when (de)serializing NBT, renaming getCobbleLocation function - EntityAIStructureMiner.java: renamed REQUEST_BATCH, more renaming and adapting to the new naming, removed getLadderBackFillBlock function hardcoding cobble and netherrack, functions now use getMainFillBlock - MineColonies.java: Renaming Tag - MinerLevelManagementModule.java: renaming function - SchematicTagConstants.java: Renaming cobbletag to tag ladderback
|
|
In order for this pull request to be merged, make sure you test whether your changes work.If the changes are working as intended, remove the https://github.com/ldtteam/minecolonies/labels/undefined label from the pull request. Contributors, please review this pull request! |
|
i accidentially linked the wrong ticket... |
src/main/java/com/minecolonies/api/util/constant/SchematicTagConstants.java
Outdated
Show resolved
Hide resolved
- EntityCitizenWalkToProxy.java: referenced getCobbleLocation, fixed - InteractionValidatorInitializer.java: referenced getCobbleLocation, fixed - MinerLevel.java: referenced getCobbleLocation, fixed, renamed vars
Tested in with the `gradew runClient`. Redstone block ladders are now possible :D
-> Wiki should recommend to use as fillerblock what ever the style uses as ladderback block. Otherwise when building the central shaft the ladder will be deconstructed and rebuild in the process. |
|
Isn't this the same as: #11573? What's the dif? |
|
Target branch |
yeah, the target branch, i got told that if i wanna have it in 1.21.1 i should do a separate PR targeting that version :) |
5 participants
Closes #
Closes #
Changes proposed in this pull request
Review please