PR for floating point fix in overlapRectangle #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2018 17:15
…s and searching for exact points.
added 2 commits
January 29, 2018 17:36
…cope for this PR, but it is what it is.
Author
|
Apologies, but I don't have the time to keep moving code around to make Travis happy. Methinks that it is being a bit stricter than it needs to be, and the issues that it is throwing is outside the scope for this PR as it was failing on a file that was not even edited by me until the final commit. |
Member
|
yeah don't worry about that, I have no idea why those are function expressions instead of declarations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33
This patch introduces an epsilon in
overlapRectangleto accommodate floating point precision errors when searching for exact points within an rtree. I selected1e-6for the epsilon, but it's possible that this is too large of an error to be acceptable for general use.