-
Notifications
You must be signed in to change notification settings - Fork 135
feat: Add Array.scan{l,r,lM,rM} #1589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmlsharp
wants to merge
23
commits into
leanprover-community:main
Choose a base branch
from
cmlsharp:scan-array
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+631
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
WIP |
Contributor
Author
|
awaiting-review |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 12, 2026
Collaborator
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting-review
This PR is ready for review; the author thinks it is ready to be merged.
builds-mathlib
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Array equivalents of List.scan{l,r,L,R}. It was originally part of #1581.
Array.scanlandArray.scanrin terms of them. This is identical to how the standard library currently handlesArray.fold*.unsafein the implementations of the efficient versions. It defines an assumption (asArray.size_fits_usize) as well as anunsafeproof of this assumption (asArray.unsafe_size_fits_usize).These are currently public definitions. I could make them private, but they seem useful for writing other 'efficient' array functions.Array.scanlMis proven to be equivalent to its efficient implementation under the assumption thatArray.size_fits_usizeholds. The efficient version ofArray.scanrMadditionally uses this assumption when constructing the proofs for the bounds checks.Array.scanrMis equivalent to its efficient version underArray.size_fits_usize. It should be possible, but the structure of these two implementations differ more, so the proof is more difficult. WithArray.scanlMthe only difference between the implementations was the use ofUSizeorNatfor the index, whereas theArray.scanrMreference implementation builds the array, then reverses it and the efficient implementation iterates over the array in reverse.