feat(Data/BitVec): add lemmas about pow on BitVec
#1608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Jan 7, 2026
Collaborator
|
Mathlib CI status (docs):
|
Contributor
|
Do we want the |
Member
Author
|
zpow doesn't exist on BitVec, or in batteries at all. |
Contributor
|
Oh, well, never mind then :) - this looks good! |
fgdorais
reviewed
Jan 18, 2026
| theorem toNat_pow (b : BitVec w) (n : Nat) : (b ^ n).toNat = (b.toNat ^ n) % (2 ^ w) := by | ||
| induction n <;> simp_all [Lean.Grind.Semiring.pow_succ] | ||
|
|
||
| theorem ofNat_pow (n : Nat) (x d : Nat) : BitVec.ofNat n (x ^ d) = BitVec.ofNat n x ^ d := by |
Collaborator
There was a problem hiding this comment.
I wish BitVec functions were more consistent using w for bit width.
Suggested change
| theorem ofNat_pow (n : Nat) (x d : Nat) : BitVec.ofNat n (x ^ d) = BitVec.ofNat n x ^ d := by | |
| theorem ofNat_pow (w x d : Nat) : BitVec.ofNat w (x ^ d) = BitVec.ofNat w x ^ d := by |
Why isn't this simp?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.