fix: better timeouts #139
Open
fix: better timeouts #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneugster
commented
Oct 27, 2023
Comment on lines
+331
to
+340
| // Catch loss of internet connection | ||
| try { | ||
| const editor = React.useContext(MonacoEditorContext) | ||
| const model = editor.getModel() | ||
| if (!model) { | ||
| return <p>no internet?</p> | ||
| } | ||
| } catch { | ||
| return <p>no internet??</p> | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This should eventually be replaced. Currently the oneLineEditor still causes troubles because of an undefined uri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP changes to improve timeouts or connection issues.
The desired behaviour in this first step would be that if the internet connection is broken, then nothing happens but the editor is still visible and selectable. In a second step, a pop-up like in lean4web could be shown.
Addresses #134, #136, #138