Skip to content

chore: backtick identifiers in do-tactic attribute messages #11844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alok wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

chore: backtick identifiers in do-tactic attribute messages #11844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Lean/Elab/Tactic/Do/Attr.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ private def mkSpecTheorem (type : Expr) (proof : SpecProof) (prio : Nat) : MetaM
-- cf. mkSimpTheoremCore
let type ← instantiateMVars type
unless (← isProp type) do
throwError "invalid 'spec', proposition expected{indentExpr type}"
throwError "invalid `spec`, proposition expected{indentExpr type}"
withNewMCtxDepth do
let (xs, _, type) ← withSimpGlobalConfig (forallMetaTelescopeReducing type)
let type ← whnfR type
Expand All @@ -185,7 +185,7 @@ def mkSpecTheoremFromConst (declName : Name) (prio : Nat := eval_prio default) :
mkSpecTheorem type (.global declName) prio

def mkSpecTheoremFromLocal (fvar : FVarId) (prio : Nat := eval_prio default) : MetaM SpecTheorem := do
let some decl ← fvar.findDecl? | throwError "invalid 'spec', local constant not found"
let some decl ← fvar.findDecl? | throwError "invalid `spec`, local constant not found"
mkSpecTheorem decl.type (.local fvar) prio

def mkSpecTheoremFromStx (ref : Syntax) (proof : Expr) (prio : Nat := eval_prio default) : MetaM SpecTheorem := do
Expand Down Expand Up @@ -225,7 +225,7 @@ def mkSpecAttr (ext : SpecExtension) : AttributeImpl where
impl.add declName stx attrKind
catch e =>
trace[Elab.Tactic.Do.specAttr] "Reason for failure to apply spec attribute: {e.toMessageData}"
throwError "Invalid 'spec': target was neither a Hoare triple specification nor a 'simp' lemma"
throwError "Invalid `spec`: target was neither a Hoare triple specification nor a `simp` lemma"
discard <| go.run {} {}

builtin_initialize registerBuiltinAttribute (mkSpecAttr specAttr)
Expand Down
Loading