Skip to content

feat: grind annotations in Init.Data.Nat.Div.Basic #11913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pirapira wants to merge 2 commits into from
Closed

feat: grind annotations in Init.Data.Nat.Div.Basic #11913

pirapira wants to merge 2 commits into from

Conversation

@pirapira
Copy link

@pirapira pirapira commented Jan 6, 2026 •
edited
Loading

This PR adds grind annotations to mod_zero and mul_div_right.

@pirapira pirapira marked this pull request as ready for review January 7, 2026 11:59
@pirapira pirapira requested a review from kim-em as a code owner January 7, 2026 11:59
@pirapira
Copy link
Author

pirapira commented Jan 7, 2026

changelog-library

@github-actions github-actions bot added the changelog-library Library label Jan 7, 2026
@pirapira pirapira marked this pull request as draft January 7, 2026 12:01
@pirapira pirapira changed the title feat: grind annotations for Init.Data.Nat.Div.Basic feat: grind annotations in Init.Data.Nat.Div.Basic Jan 7, 2026
@pirapira pirapira marked this pull request as ready for review January 7, 2026 12:01
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 7, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 7, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11913
b6fc628
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Jan 7, 2026
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Jan 7, 2026
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11913
d431619
leanprover-bot added a commit to leanprover/reference-manual that referenced this pull request Jan 7, 2026
@leanprover-bot
Update lean-toolchain for testing leanprover/lean4#11913
39aa874
@leanprover-bot leanprover-bot added the builds-manual CI has verified that the Lean Language Reference builds against this PR label Jan 7, 2026
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Jan 7, 2026 •
edited
Loading

Reference manual CI status:

@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 7, 2026
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 7, 2026

Mathlib CI status (docs):

@kim-em
Copy link
Collaborator

kim-em commented Jan 9, 2026

These facts shouldn't be handled by grind annotations. Please contact me on the zulip, and describe the examples where you think you need these annotations, and we'll see if there are alternative solutions.

@kim-em kim-em closed this Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees

No one assigned

Labels

builds-manual CI has verified that the Lean Language Reference builds against this PR builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pirapira @leanprover-bot @leanprover-community-bot @kim-em