feat: add typeclass instances for common types #11924
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `Append` typeclass instances for `SubExpr.Pos` and `Meta.FVarSubst`, enabling the use of the `++` operator for these types. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Add the following instances: - LT, Decidable (a < b), BEq for TransparencyMode - LT, Decidable (a < b), Ord for Position - LT, Decidable (a < b) for ReducibilityHints - Append for RBTree - Membership for RBTree - Membership for PersistentHashSet - Append, Singleton, Union, Membership for NameHashSet - Membership for NameSet 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
alok
changed the title
Append instances for SubExpr.Pos and FVarSubstAdd Union, SDiff, Singleton, and Inter instances for RBTree. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
Collaborator
|
Reference manual CI status:
|
Collaborator
|
TransparencyMode and ReducibilityHints could have LE and Ord while we're here. |
Collaborator
|
PR descriptions must start with "This PR", otherwise the automatic changelog scripts will get confused. I'm surprised CI didn't tell you this! (edit: not all CI checks run on drafts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds typeclass instances for common types in the Lean library to enable standard syntax for append, ordering, set operations, membership, and iteration.
Summary
Append instances
SubExpr.Pos- enables using++to concatenate subexpression positionsMeta.FVarSubst- enables using++to compose free variable substitutionsRBTree- enables using++to union red-black treesNameHashSet- enables using++to union name hash setsLT/LE/Ord instances
TransparencyMode- LT, LE, Ord, Decidable (a < b), BEqPosition- LT, Decidable (a < b), Ord, LEReducibilityHints- LT, LE, Decidable (a < b)Set operation instances (RBTree)
Union- enabless ∪ tsyntaxSDiff- enabless \\ tsyntaxInter- enabless ∩ tsyntaxSingleton- enables{a}syntaxMembership instances
RBTree- enables∈syntax for membership testingPersistentHashSet- enables∈syntax for membership testingNameSet- enables∈syntax for membership testingNameSSet- enables∈syntax for membership testingNameHashSet- enables∈syntax for membership testingSSet- enables∈syntax for membership testingForIn instances
SSet- enablesfor x in s do ...iterationNameSSet- enablesfor x in s do ...iterationOther instances
NameHashSet- Singleton, UnionAll types already had the corresponding methods defined; this simply adds the typeclass instances to enable standard syntax.
Total: 27 new typeclass instances across 9 files
Test plan
make -j -C build/release#synth