Sh1106 oled screen supported #83
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoesbergen
requested changes
Nov 23, 2025
Member
rmoesbergen
left a comment
rmoesbergen
left a comment
There was a problem hiding this comment.
Black is nog niet helemaal blij. Daarna is pylint ook nog aan de beurt. Vergeet bovendien niet om de bestanden ook toe te voegen aan de package.json.
| @@ -0,0 +1,70 @@ | |||
| """This module provides OLED SSH1106 methods""" | |||
Member
There was a problem hiding this comment.
Dit bestand heeft dezelfde inhoud als sh11_scherm.py. Kun je 1 van de 2 verwijderen en misschien een betere naam bedenken?
| """ | ||
| Initializes the OLED screen using the SSH1106 driver. | ||
| Args: |
Member
There was a problem hiding this comment.
Deze comments / parameters staan ook al bij init, dat hoeft maar 1 keer.
| instance.initialize_device() | ||
| instance.reinitialize = False | ||
| except RuntimeError: | ||
| if instance.show_warnings == True: |
Member
There was a problem hiding this comment.
Suggested change
| if instance.show_warnings == True: | |
| if instance.show_warnings: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for a new model of oled display.
The old drivers werent working anymore for this model so this pull request adds support for this model.