Skip to content

Installing anaconda Instruction #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Mar 20, 2024

Conversation

emma0925
Copy link
Collaborator

@emma0925 emma0925 commented Mar 19, 2024

This PR solves the aspects mentioned in Issue #484, it reconstructed and elaborated on the existing Setup_conda.md.

  • Moved the introduction of Conda to a new file 'Introduce_Conda.md' and added a redirect link to the Setup_conda.md
  • Add the Installation Instruction for Anaconda for both MacOS and Windows, which wasn't mentioned in the originial Setup_conda.md

@emma0925 emma0925 requested a review from YankeMao March 19, 2024 22:14
Copy link
Collaborator

@YankeMao YankeMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things should be improved:

  1. There are some pictures waiting to be added for the section about the installation of the Anaconda on MacOS.
  2. The re-direct link in the section about the installation of the Anaconda on MacOS would re-direct to the wrong position. It should re-direct to the sections about the installation of the Anaconda on Windows and Linux respectively.
  3. When describing the installation of Anaconda, it is worth giving some suggestions such as remembering to add conda to the environment path during installation,
  4. the content on the install_conda.md and the Setup_Conda.md were overlapped. Only need to keep one of them.

@emma0925
Copy link
Collaborator Author

There are a few things should be improved:

  1. There are some pictures waiting to be added for the section about the installation of the Anaconda on MacOS.
  2. The re-direct link in the section about the installation of the Anaconda on MacOS would re-direct to the wrong position. It should re-direct to the sections about the installation of the Anaconda on Windows and Linux respectively.
  3. When describing the installation of Anaconda, it is worth giving some suggestions such as remembering to add conda to the environment path during installation,
  4. the content on the install_conda.md and the Setup_Conda.md were overlapped. Only need to keep one of them.

Thank you for your comment.

  • I had fixed the images path, so it is displaying now.
  • I also fix the redirect link.
  • mentioned to add conda to the environment path during installation
  • Removed the duplicated file intallation.md

@muyuxuan946
Copy link
Collaborator

Hey Emma, considering the extensive nature of this document, it might be more convenient to split it into several files, each addressing distinct sections or topics. Such as install and setup can be in two separate files. Additionally, to enhance navigability, incorporating a table of contents at the beginning can provide a clear roadmap for easy reference. This approach would ensure better organization and accessibility of information.

@muyuxuan946
Copy link
Collaborator

Oh also, there is no pr description. It's better to add one to clarify.

@emma0925 emma0925 requested a review from muyuxuan946 March 20, 2024 00:59
@emma0925
Copy link
Collaborator Author

@muyuxuan946 @YankeMao I have revised according to your comments. Please take another look. Thanks

@emma0925 emma0925 requested a review from YankeMao March 20, 2024 02:28
Copy link
Collaborator

@YankeMao YankeMao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants