Skip to content

Adding Google Maps JavaScript API #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dannyaudi
Copy link

No description provided.

Copy link
Collaborator

@HubertGu HubertGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great contribution. The tutorial for using Google Maps API is very detailed for beginners to learn. Consider adding links to text for ease of use for the reader, and after resolving the conflict this can be merged.


https://developers.google.com/maps/documentation/javascript/adding-a-google-map#maps_add_map-javascript

Note that this guide DOES NOT work for a React website, users working in a react environment must follow the "Embedding a Google Map on a React Website" section.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider linking "Embedding a Google Map on a React Website" to its corresponding section.


Users utilizing this package must make sure to run `npm install @react-google-maps/api` or add the package to their dependencies before running the website.

The individual compenents that the user wishes to use must also be included in the imports at the beginning of whichever files they are used in. A full list of the package components and their properties can be found in the "react-google-maps-api-docs" guide link of this section. For example, a user creating a custom map and adding markers to it would perform the following at the beginning of their JavaScript file:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a link for the "react-google-maps-api-docs". You can use [text](link) to add a link to the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants