Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docker hot reload #11586

Closed

Conversation

ThEditor
Copy link
Contributor

@ThEditor ThEditor commented Dec 5, 2023

Summary

  • Added make docker-devserver-hot inside Makefile
  • Added devhot.dockerfile
  • Implemented hot reloading for docker development server

References

Closes #11585

Reviewer guidance

Setup kolibri using docker

  • make docker-build-base
  • make docker-devserver-hot

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob
Copy link
Member

MisRob commented Dec 7, 2023

Hi @ThEditor, thanks for your contribution. We've got some refactor in progress #11443 and I am not sure how this will fit into it. I asked relevant folks for review, so let's see. cc @vkWeb

@vkWeb
Copy link
Member

vkWeb commented Dec 8, 2023

@ThEditor I really appreciate your initiative of looking into this and creating a pull request. We already have some work planned on #11443 to overhaul our docker setup for development purposes. As I can see from this PR, you look pretty familiar with Makefile, dockerfile and I can observe your enthusiasm to solve this.

We will love your help with #11443, so can you please email me on -- [email protected] (we will schedule a google meet), we will together work to complete #11443.

Closing this PR in favour of #11443.

@vkWeb vkWeb closed this Dec 8, 2023
@MisRob
Copy link
Member

MisRob commented Dec 8, 2023

@vkWeb @ThEditor I also linked #11585 to @vkWeb's work in progress

@ThEditor
Copy link
Contributor Author

ThEditor commented Dec 8, 2023

@vkWeb I've sent you a mail, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants