Manage users in LOD #12228
Open
Manage users in LOD #12228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Build Artifacts
|
marcellamaki
added this to the Kolibri 0.17: General maintenance, bugs, misc. important fixes milestone
github-actions
bot
added
APP: Setup Wizard
AlexVelezLl
force-pushed
the
manage-user-lod
branch
from
0f51871
to
4c45c09
Compare
github-actions
bot
added
the
APP: User
rtibbles
modified the milestones:
Kolibri 0.17: General maintenance, bugs, misc. important fixes,
Kolibri 0.18: General maintenance
rtibbles
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Some quick feedback - I've raised my main concern (which is more with the original spec, than the work you have done here) on Slack for further discussion, but ultimately I think having this as a separate SPA is not the right direction - but we'll see what the discussion leads us to.
| @@ -210,6 +211,9 @@ export default { | |||
| }, | |||
| resources, | |||
| themeConfig, | |||
| machines: { | |||
| importLodUsersMachine, | |||
There was a problem hiding this comment.
I think I'd rather put this in kolibri-common rather than add it to the core API spec.
| @@ -4,7 +4,7 @@ export default function UserType(userObject) { | |||
| if (userObject.is_superuser) { | |||
| return UserKinds.SUPERUSER; | |||
| } | |||
| if (!userObject.roles.length) { | |||
| if (!userObject.roles || !userObject.roles.length) { | |||
There was a problem hiding this comment.
No need to change but could also do:
if (!userObject?.roles.length) {
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
(I feel like you used this in the useBaseSearch refactor work)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lodOnlyprop on registerNavItem to register nav items just for LOD devices.core.auth.deleteimporteduserendponit to remove a user in LOD devices along with its certificates and morango metadata.Screencasts
Compartir.pantalla.-.2024-06-26.18_35_32.mp4
Compartir.pantalla.-.2024-06-26.18_38_21.mp4
Compartir.pantalla.-.2024-06-26.18_33_36.mp4
References
Closes #12226
Reviewer guidance
Follow the specs.
Testing checklist
PR process
Reviewer checklist
yarnandpip)