Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource discovery: Implement channel card #12607

Merged
merged 14 commits into from
Oct 16, 2024

Conversation

AllanOXDi
Copy link
Member

Summary

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Aug 27, 2024
@MisRob
Copy link
Member

MisRob commented Aug 28, 2024

@AllanOXDi please let me know when this is ready for final review. I was just going through all card work so I left some notes here already for important changes. However, I think after that's done, there won't be much else here, perhaps some minor details. Nice work overall.

@AllanOXDi AllanOXDi force-pushed the accessible-channel-card branch 2 times, most recently from c9dcad2 to 18deedc Compare September 27, 2024 18:49
@AllanOXDi AllanOXDi changed the title [DO NOT MERGE until #12418]Accessible channel card Resource discovery: Implement channel card Sep 27, 2024
@AllanOXDi
Copy link
Member Author

@MisRob would you mind giving this another look?

@MisRob
Copy link
Member

MisRob commented Oct 7, 2024

Hi @AllanOXDi, yes - would you please clean up temporary code? As I've already seen this before, I think I will only do a final pre-merge review when everything's ready. Thanks for preparing everything for easier testing :)

@MisRob MisRob self-assigned this Oct 8, 2024
@AllanOXDi
Copy link
Member Author

Done!

@AlexVelezLl
Copy link
Member

Hey @AllanOXDi! I just merged #12717 which had some KCard breaking changes. Could you please rebase the branch, and update the layout prop to orientation as this is one of the breaking changes introduced in the latest KDS version https://github.com/learningequality/kolibri-design-system/releases/tag/v5.0.0-rc7 :)

@MisRob
Copy link
Member

MisRob commented Oct 15, 2024

Two last things, @AllanOXDi, and then can be merged :)

@github-actions github-actions bot added the APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) label Oct 15, 2024
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AllanOXDi

@MisRob MisRob merged commit aa97a15 into learningequality:develop Oct 16, 2024
34 checks passed
@AllanOXDi AllanOXDi deleted the accessible-channel-card branch October 16, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants