KModal appendToRoot changed to appendToOverlay #12659
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously changed from
appendToBody
toappendToRoot
671ccf1@MisRob pointed out these should be
appendToOverlay
now instead.References
Tests on #12651 should pass after this is merged and that dependabot branch is rebased.
Also is blocking #12571 to some degree so it should be rebased when this is merged.
Reviewer guidance