Used KTextTruncator in ReviewSelectionsPage to avoid text collision #4870
Conversation
There was a problem hiding this comment.
I have tested the changes locally and the text collision does not exist now. Thanks @shruti862!
There was a problem hiding this comment.
Hi @shruti862, thanks! Even though this resolved the text collision, there is a regression. Previously, items in the list would be formatted as links, and clicking the item would open a resource. This functionality is now lost. #4086 needs to be fixed in a way that doesn't break this.
I believe that in #4591, @lokesh-sagi125 works on some other places that need KTextTruncator and is currently dealing with some things related to ActionLink and KTextTruncator that could perhaps be relevant here as well. @lokesh-sagi125 would you coordinate with @shruti862 and mention more details?
|
yes @MisRob even though my implementation is still acting like a link , the underline part is not inherited. will try researching other possible solutions:) |
|
Hey @lokesh-sagi125 , I am currently working on implementing text truncation using the KTextTruncator component along with ActionLink, and I was wondering if you could share your approach , may be it can help me. |
|
Hi @shruti862, are you on our Slack? There's outline of next steps in this thread that @lokesh-sagi125 opened. I believe it'd be helpful to coordinate with your work. |
|
Hey @MisRob ! Yes, I’m on Slack., I’ll go through the thread that @lokesh-sagi125 opened and coordinate accordingly. Thanks for the heads-up! |
|
Hi @shruti862, do you still plan to return to this work? |
|
Hey @MisRob, I apologize for the delay. I am planning to revisit this issue soon. |
|
No problem at all, just checking on status. Thanks @shruti862 |
Summary
Added KTextTruncator in ReviewSelectionsPage to avoid resource title collision with Channel name.
After Change:
…
References
Fixes issue #4086
…
Reviewer guidance
…