Skip to content

Fixed issue #4757 by modying ContextMenuCloak.vue #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Fixed issue #4757 by modying ContextMenuCloak.vue #4958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions contentcuration/contentcuration/frontend/shared/views/ContextMenuCloak.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,12 @@
return !this.disabled && this.currentContextMenu === this._uid;
},
},
mounted() {
document.addEventListener('click', this.hideMenu);
},
beforeDestroy() {
document.removeEventListener('click', this.hideMenu);
},
methods: {
...mapMutations('contextMenu', { setMenu: 'SET_CONTEXT_MENU' }),
showMenu(e) {
Expand All @@ -37,8 +43,14 @@
this.y = e.clientY;
this.setMenu(this._uid);
},
hideMenu(e) {
if (this.currentContextMenu && !this.$el.contains(e.target)) {
this.setMenu('');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High-level, it seems to me it'd make more sense to setMenu('') from the ContextMenu component in the moment when it's being closed? Since it logically corresponds to the user action.

That could perhaps help with some other issues I raised, and it would improve readability.

Let's chat about why you chose this approach.

Copy link
Contributor Author

@Arunima22 Arunima22 Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MisRob Thank you for your reply. I will be happy to experiment with the second approach you suggested where we try to reset global variables from ContextMenu itself.

I was trying to figure out the root cause of this issue before. But why precisely the variables were not resetting in the first place was something I couldn't figure out. I was trying to understand the root of it and tried to isolate the issue as well by deleting the other code but my approach was unsuccessful. One thing that I repeatedly saw was that we were not able to receive the updated value of uid while trying to display the menu. That is why I used a listener object.

Copy link
Member

@MisRob MisRob Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - that sounds it may be useful to take a step back and try some thorough debugging one more time, before we decide the final technique to resolve this. It may be some sort of issue with reactivity as well, and those can be a bit tricky. You could try to trace step by step and take some notes about what's exactly happening when the cloak is clicked for the first time, then for the second time, and what's the difference. Feel free to share your findings with code references.

It seems it will be indeed related to resetting those global variables, and it is logical for us to reset them in any case, so now it's just about digging even deeper.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I will work on this in the upcoming week. I will post my notes here.

}
},
extendSlot,
},

render() {
if (this.disabled) {
return this.extendSlot('default');
Expand Down