Updated collection link and modal in channelSetList #5257
Conversation
|
Thanks again @yeshwanth235! To this pull request, we will too assign a reviewer next week. |
| </div> | ||
| </template> | ||
| <template #actions> | ||
| <KButton @click="infoDialog = false"> {{ $tr('cancelButtonLabel') }} </KButton> |
There was a problem hiding this comment.
I don't think this is necessary, We could just use the inbuilt cancel and submit labels and events that come with the KModal. please see the documentation here. Both cancel and submit are optional
There was a problem hiding this comment.
Essentially, let's not use the actions slot
| <VBtn @click="infoDialog = false"> | ||
| {{ $tr('cancelButtonLabel') }} | ||
| </VBtn> | ||
| <template> |
There was a problem hiding this comment.
This template wrapping is probably not necessary too
| <ActionLink | ||
| <KButton | ||
| :text="$tr('aboutChannelSetsLink')" | ||
| class="mx-2" |
There was a problem hiding this comment.
Can we implement our own css (with an appropriate name) so we completely clean up any vuetify related code from this change. I think mx-2 applies a margin of 8px on the left and right of the button.
There was a problem hiding this comment.
Hi @akolson
Need your input here.
Should I create a new class for this margin in this component? or
Should I create a new SCSS file for generic, project-wide styles?
There was a problem hiding this comment.
A new class will do within the ChannelSetList.vue component should do just fine.
There was a problem hiding this comment.
Updated the pr @akolson. Please help to review
There was a problem hiding this comment.
Great work @yeshwanth235! Just a few clean up notes and we should be good!
| <p> | ||
| {{ $tr('channelSetsInstructionsText') }} | ||
| </p> | ||
| <p :style="{ color: $themePalette.red.v_500 }"> |
There was a problem hiding this comment.
@yeshwanth235 can we use a class instead for this (as its better maintainable)? That is by defining a computed prop and using :class="$computedClass(channelSetsDisclamerStyle)" instead?
There was a problem hiding this comment.
updated it @akolson
There was a problem hiding this comment.
For future work, just noting that ordinary dynamic :style=channelSetsDisclamerStyle would work too ($computedClass use is needed for few special cases when :style cannot be used - e.g. for pseudo-selectors)
There was a problem hiding this comment.
Hi @yeshwanth235! One more change and we should be good with this issue. Thanks and great work!
Summary
Updated ActionLink to KButton
Updated MessageDialog to KModal
Screenshots:
References
5234
Reviewer guidance
Test new KButton and KModal in channels/#/collections
It should be working as expected.