-
Notifications
You must be signed in to change notification settings - Fork 227
[Remove Vuetify from Studio] Delete, restore, and visibility confirmation dialogs in admin channel actions #5416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: unstable
Are you sure you want to change the base?
Conversation
…d classes to content and title for proper behaviour
Hi @MisRob, I've updated the ChannelActionsDropdown.spec.js tests (Locally) after migrating to KModal as i saw the tests failing. Changes: Let me know if you have any feedback and then i will update the Pr. |
Thank you @Prashant-thakur77, we will assign a reviewer next week. |
@MisRob I would appreciate your guidance on how to set the themeToken.text color for the title in the KModel component. I was able to apply it successfully to the content since it was within a tag, but I’m a bit unsure about how to correctly apply it to the title text. |
If you're referring to
it's best to not override |
So you can just remove the above part from the code :) Generally tokens can be only applied via computed style or class as described here. But again, here I think you won't need it. |
@MisRob The issue I’m facing is that when the Delete Channel action is triggered, the text across the entire table turns red. Since the modal is a child of this parent component, the text within the KModal — both the title and content — also inherits the red color when the modal is restored or when Permanently Delete is clicked. I’ve managed to fix the content color issue by applying inline styles directly to the div, but I’m uncertain about the correct way to set the title text color. Additionally, since the table components are center-aligned by default, applying a left alignment to the modal text and title seems important — otherwise, both elements appear centered within the modal. |
That's helpful @Prashant-thakur77, thank you. It'd be best to fix this right in |
Sure @MisRob i would love to do it. |
Thank you @Prashant-thakur77. So the first step would be to try if this suggestion helps with this Studio use-case. This is development documentation for KDS. Note that information on linking is obsolete in the dev docs. You can link your local KDS to local Studio with running these commands in Studio: |
Fixes #5410
Summary
Migrated 5 channel action confirmation dialogs from Vuetify to KDS KModal
Changed title of the soft delete button from"Permanently delete channel" to "delete channel" for proper distinction (after confirming from misrob)
After images for Desktop users:
After images for Mobile users:
References
• Parent issue: #5060
Reviewer guidance
Login as [email protected] with password a
Go to Administration > Channels
Click Actions dropdown in the last column of the table
Click Make public / Make private / Delete channel / Restore / Delete pernamently (note that availability of these options depends on channel type).