Skip to content

add validation for empty tasks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdjihadalom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add validation for empty tasks #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@
*
*/

// select elements & assign them to variables
let newTask = document.querySelector('#new-task');
let form = document.querySelector('form');
let todoUl = document.querySelector('#items');
let completeUl = document.querySelector('.complete-list ul');
// select elements & assign them to variables
let newTask = document.querySelector('#new-task');
let form = document.querySelector('form');
let todoUl = document.querySelector('#items');
let completeUl = document.querySelector('.complete-list ul');


// functions
let createTask = function(task) {
let createTask = function (task) {
let listItem = document.createElement('li');
let checkBox = document.createElement('input');
let label = document.createElement('label');
Expand All @@ -28,16 +28,22 @@ let createTask = function(task) {
return listItem;
}

let addTask = function(event) {
let addTask = function (event) {
event.preventDefault();
let listItem = createTask(newTask.value);
todoUl.appendChild(listItem);
newTask.value = "";
// bind the new list item to the incomplete list
bindInCompleteItems(listItem, completeTask);

if (newTask.value.trim() !== "") {
let listItem = createTask(newTask.value);
todoUl.appendChild(listItem);
newTask.value = "";
// bind the new list item to the incomplete list
bindInCompleteItems(listItem, completeTask);
} else {
window.alert("Please write a valid task!");
}

}

let completeTask = function() {
let completeTask = function () {
let listItem = this.parentNode;
let deleteBtn = document.createElement('button');
deleteBtn.innerText = 'Delete';
Expand All @@ -50,27 +56,27 @@ let completeTask = function() {
bindCompleteItems(listItem, deleteTask);
}

let deleteTask = function() {
let deleteTask = function () {
let listItem = this.parentNode;
let ul = listItem.parentNode;
ul.removeChild(listItem);
}

let bindInCompleteItems = function(taskItem, checkboxClick) {
let bindInCompleteItems = function (taskItem, checkboxClick) {
let checkBox = taskItem.querySelector('input[type="checkbox"]');
checkBox.onchange = checkboxClick;
}

let bindCompleteItems = function(taskItem, deleteButtonClick) {
let bindCompleteItems = function (taskItem, deleteButtonClick) {
let deleteButton = taskItem.querySelector('.delete');
deleteButton.onclick = deleteButtonClick;
}

for(let i=0; i< todoUl.children.length; i++ ) {
for (let i = 0; i < todoUl.children.length; i++) {
bindInCompleteItems(todoUl.children[i], completeTask);
}

for(let i=0; i< completeUl.children.length; i++ ) {
for (let i = 0; i < completeUl.children.length; i++) {
bindCompleteItems(completeUl.children[i], deleteTask);
}

Expand Down