Fix bug related to Podfile.lock-only changes #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where copying the generated framework after a build would fail if the framework already exists in the GeneratedFrameworks folder, even if that existing framework is out-of-date.
|
Can we please get this in? Seems good to me. |
|
This is the fix that this repo needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CocoaPods-Binary appears to be checking the
Podfileagainst theManifest.lockto determine if changes occurred and a pod needs to be rebuilt. However, when the version of a pod is changed only in thePodfile.lock(for example, another git user callspod updateand you pull that change), then it appears CocoaPods-Binary doesn't detect the changes.This PR includes a test case to detect the issue, and fixes it by comparing the
Manifest.lockafter CocoaPods has done dependency resolution.Note: This PR is built on top of #103 and #84 since both of those are needed for this PR to pass CI.