Skip to content

Pass custom help formatter to subparsers (#336) #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Pass custom help formatter to subparsers (#336) #339

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f9314d
Pass custom help formatter to subparsers (#336)
zrlf Jan 30, 2025
72cea15
Fix formatting in field_wrapper.py
lebrice Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion simple_parsing/wrappers/field_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,7 +1021,7 @@ def add_subparsers(self, parser: ArgumentParser):
# subparsers.required = default_value is dataclasses.MISSING
for subcommand, dataclass_type in self.subparsers_dict.items():
logger.debug(f"adding subparser '{subcommand}' for type {dataclass_type}")
subparser = subparsers.add_parser(subcommand)
subparser = subparsers.add_parser(subcommand, formatter_class=parser.formatter_class)
# Just for typing correctness, as we didn't explicitly change
# the return type of subparsers.add_parser method.)
subparser = cast("ArgumentParser", subparser)
Expand Down