WIP: feat(xact): add default time when copying transaction#281
Open
Fuco1 wants to merge 1 commit intoledger:masterfrom
Open
WIP: feat(xact): add default time when copying transaction#281Fuco1 wants to merge 1 commit intoledger:masterfrom
Fuco1 wants to merge 1 commit intoledger:masterfrom
Conversation
Fuco1
changed the title
Contributor
Author
|
For some reason the default time is shifted one day back, I think it might be some time-zone related issue with org read date. |
Contributor
Author
|
Oh, this actually changes the behaviour when user only hits RET upon the query. It will copy to the original date instead of today. I think that is a significant breaking change unfortunately :( I still want to have some option to add past transactions easily, so I'll play with this a little bit more. |
Fuco1
force-pushed
the
feature/default-time-copy-xact
branch
from
8da4d98 to
65b7fcf
Compare
Use the transaction's time as default time when asking when the copy should be created. This allows us to use the relative syntax of org-read-date to move the transaction an <interval> forward or backward from the time of the transaction: +1d (+ 1 day from TODAY) ++1d (+ 1 day from DEFAULT-TIME, i.e. date of the original transaction) In other words, single +/- is relative against today and double ++/-- is relative against the DEFAULT-TIME. Note that since currently the DEFAULT-TIME is today, this feature is only strictly adding functionality and should therefore be fully backward-compatible.
Fuco1
force-pushed
the
feature/default-time-copy-xact
branch
from
65b7fcf to
58fe513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the transaction's time as default time when asking when the copy should be
created. This allows us to use the relative syntax of org-read-date to move the
transaction an
<interval>forward or backward from the time of the transaction:+1d (+ 1 day from TODAY)
++1d (+ 1 day from DEFAULT-TIME, i.e. date of the original transaction)
In other words, single +/- is relative against today and double ++/-- is
relative against the DEFAULT-TIME (see C-h f
org-read-date).Note that since currently the DEFAULT-TIME is today, this feature is only
strictly adding functionality and should therefore be fully backward-compatible.