Skip to content

Charge trapping Correction with a minimzer for LQ#163

Draft
DaGeibl wants to merge 6 commits intolegend-exp:mainfrom
DaGeibl:lq_ctc
Draft

Charge trapping Correction with a minimzer for LQ#163
DaGeibl wants to merge 6 commits intolegend-exp:mainfrom
DaGeibl:lq_ctc

Conversation

@DaGeibl
Copy link
Contributor

@DaGeibl DaGeibl commented Sep 15, 2025

This PR adds a new function for the LQ charge trapping correction. It works similar as the AoE or energy ctc. The function uses a minimizer to find the optimal correction to minimize the sigma of the DEP.
The named tuple vis can be used with a new LegendMakie recipe to produce a fit of the minimizer parameter space.

The old function is kept and a deprecation was added. I also changed the file structure of the lq functions, so that the lq_norm and the two ctc functions are in separate files.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 79.25926% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.20%. Comparing base (9333b87) to head (5d37cb9).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/lq_ctc.jl 77.22% 23 Missing ⚠️
src/lq_norm.jl 85.29% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   56.33%   57.20%   +0.86%     
==========================================
  Files          36       37       +1     
  Lines        2320     2374      +54     
==========================================
+ Hits         1307     1358      +51     
- Misses       1013     1016       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theHenks theHenks self-requested a review October 10, 2025 13:47
@theHenks theHenks added the enhancement New feature or request label Oct 10, 2025
@theHenks theHenks linked an issue Oct 10, 2025 that may be closed by this pull request
5 tasks
@DaGeibl DaGeibl marked this pull request as draft January 13, 2026 12:20
@DaGeibl
Copy link
Contributor Author

DaGeibl commented Jan 13, 2026

Converted back to draft as long as this PR is on ice.
I will open it as soon as I think that we can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Future LQ optimizations

2 participants