Charge trapping Correction with a minimzer for LQ#163
Draft
DaGeibl wants to merge 6 commits intolegend-exp:mainfrom
Draft
Charge trapping Correction with a minimzer for LQ#163DaGeibl wants to merge 6 commits intolegend-exp:mainfrom
DaGeibl wants to merge 6 commits intolegend-exp:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 56.33% 57.20% +0.86%
==========================================
Files 36 37 +1
Lines 2320 2374 +54
==========================================
+ Hits 1307 1358 +51
- Misses 1013 1016 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
Contributor
Author
|
Converted back to draft as long as this PR is on ice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new function for the LQ charge trapping correction. It works similar as the AoE or energy ctc. The function uses a minimizer to find the optimal correction to minimize the sigma of the DEP.
The named tuple
viscan be used with a new LegendMakie recipe to produce a fit of the minimizer parameter space.The old function is kept and a deprecation was added. I also changed the file structure of the lq functions, so that the lq_norm and the two ctc functions are in separate files.